Convert uriIndex cookies to a list before processing#41
Open
vicky7230 wants to merge 1 commit intogotev:masterfrom
Open
Convert uriIndex cookies to a list before processing#41vicky7230 wants to merge 1 commit intogotev:masterfrom
vicky7230 wants to merge 1 commit intogotev:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A ConcurrentModificationException is being thrown when iterating over a list that's being modified simultaneously. The issue is in
SharedPreferencesCookieStore.add() at line 56—theuriIndexmap is being modified while it's being iterated.The problem occurs because
SharedPreferencesCookieStore.add()callssuper.add()which modifies uriIndex, and then immediately tries to iterate over the cookies to serialize them. If another thread is also accessing the same collection, aconcurrent modification exception occurs.
Fix: Create a copy of the cookies list before iterating to avoid concurrent modification issues.
Crash stacktrace: