Expand libium's heuristic for github to use release name if only one jar is associated with the release#10
Open
garethgeorge wants to merge 1 commit intogorilla-devs:mainfrom
Open
Conversation
…jar is associated with the release
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Untested implementation that expands libium's heuristic for github releases to capture the common pattern of mod version in the release name with a single associated jar. For an example see Cow's odd widgets.
The heuristic implemented is:
This code compiles, but I'm looking for guidance on testing pattern for libium as I'm not seeing tests in the repository and ran into some issues when trying to build ferium with a local copy.