feat: [#546] artisan command up and down to set website Maintenance mode#1198
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #1198 +/- ##
==========================================
+ Coverage 68.80% 68.84% +0.03%
==========================================
Files 287 290 +3
Lines 18118 18248 +130
==========================================
+ Hits 12466 12562 +96
- Misses 5115 5136 +21
- Partials 537 550 +13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This is a fantastic PR with a very useful addition to the framework! 🎉 I have a suggestion: how about allowing an optional |
|
Please fix the windows CI. |
|
Thanks, great job 👍 Could add some related screenshots in the PR description? |
3479a4b to
b70c346
Compare
e635bf5 to
07bc616
Compare
a224b58 to
63f223a
Compare
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces up and down artisan commands to manage maintenance mode, along with a middleware to enforce it. The implementation is a good start, but there are several areas for improvement. My review focuses on enhancing error handling within the new commands to provide clearer feedback for scripting and automation, and on improving the test coverage for the new maintenance middleware to ensure all its features are working as expected. I've also identified a few issues in a test helper function that could lead to flaky tests.
hwbrzzl
left a comment
There was a problem hiding this comment.
Thanks, great PR! Just left a few questions.
80004df to
2be2fa0
Compare
dbadd5e to
619619e
Compare
|
@praem90 Thanks, checking |
hwbrzzl
left a comment
There was a problem hiding this comment.
Thanks, great job! I tested this feature locally, pretty good.
📑 Description
This PR adds two Artisan commands
The
downcommands creates a temporary file in the framework storage folderThe
upcommands removes that file if existsThere is an another middleware
CheckForMaintenance, that checks for the file.It returns the request with
503status code if the file exists else allow the request to passthrough.Closes goravel/goravel#546
✅ Checks