fix(tasks): warn when due time is ignored by API#700
fix(tasks): warn when due time is ignored by API#700jeevan6996 wants to merge 1 commit intogoogleworkspace:mainfrom
Conversation
🦋 Changeset detectedLatest commit: e225662 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a proactive warning system for the Google Tasks CLI integration. By detecting when users provide a due date with a non-midnight time component, the CLI can now inform the user that this time information will be discarded by the Google Tasks API, thereby improving transparency and preventing potential confusion regarding task scheduling. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a warning for Google Tasks API requests that include a non-midnight due time, as the API only stores the date and ignores the time-of-day. The changes include a new utility to parse the due field and logic within the executor to print a warning to stderr during POST, PUT, or PATCH operations. A security concern was raised regarding the potential for terminal escape sequence injection because the warning message includes user-controlled input; a suggestion was provided to sanitize the output before printing.
| let input = parse_and_validate_inputs(doc, method, params_json, body_json, upload.is_some())?; | ||
|
|
||
| if let Some(msg) = tasks_due_time_truncated_warning(doc, method, input.body.as_ref()) { | ||
| eprintln!("Warning: {msg}"); |
There was a problem hiding this comment.
The warning message includes the due value directly from the request body, which is user-controlled. To prevent terminal escape sequence injection, this string should be sanitized before being printed to the terminal. Note that Rust's char::is_control() only covers the Cc (Control) Unicode category, not Cf (Format), so is_dangerous_unicode is needed to check for dangerous Unicode characters.
| eprintln!("Warning: {msg}"); | |
| eprintln!("Warning: {}", sanitize_for_terminal(&msg)); |
References
- Rust's char::is_control() only covers the Cc (Control) Unicode category, not Cf (Format). Therefore, is_dangerous_unicode is not redundant and is needed to check for dangerous Unicode characters.
- Sanitize error strings printed to the terminal to prevent escape sequence injection.
2 participants
Summary
duetimestamp, since the Tasks API stores only date information and discards time-of-dayPOST/PUT/PATCH) so other APIs are unaffectedFixes #696