Skip to content

Conversation

@sugar-cat7
Copy link

What type of PR is this?
/kind feature

What this PR does / Why we need it:
promote FleetAutoscaleRequestMetaData to beta

Which issue(s) this PR fixes:

Closes #4360

Special notes for your reviewer:

@github-actions github-actions bot added kind/feature New features for Agones size/S labels Dec 1, 2025
Copy link
Collaborator

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the submission 🥳 , but I also noticed that we don't have any documentation on this feature in https://agones.dev/site/docs/reference/fleetautoscaler/#webhook-endpoint-specification

Any chance you want to also add them as part of this PR?

| [Player Tracking]({{< ref "/docs/Guides/player-tracking.md" >}}) | `PlayerTracking` | Disabled | `Alpha` | 1.6.0 |
| [Scheduled Fleet Autoscaling](https://github.com/googleforgames/agones/issues/3008) | `ScheduledAutoscaler` | Enabled | `Beta` | 1.51.0 |
| [Extend Webhook autoscaler to send fleet metadata with the request](https://github.com/googleforgames/agones/issues/3951) | `FleetAutoscaleRequestMetaData` | Disabled | `Alpha` | 1.48.0 |
| [Extend Webhook autoscaler to send fleet metadata with the request](https://github.com/googleforgames/agones/issues/3951) | `FleetAutoscaleRequestMetaData` | Enabled | `Beta` | 1.48.0 |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same things as #4364 - this shouldn't be changed, since this is the current docs that are displayed, and the feature will only move in the next version.

Copy link
Author

@sugar-cat7 sugar-cat7 Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix
d707615

@markmandel
Copy link
Collaborator

/gcbrun (not that I think there will be an issue)

@agones-bot
Copy link
Collaborator

Build Failed 😭

Build Id: 16a61980-7824-430a-bf59-834c4fe8eef8

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@sugar-cat7
Copy link
Author

Thanks for the submission 🥳 , but I also noticed that we don't have any documentation on this feature in https://agones.dev/site/docs/reference/fleetautoscaler/#webhook-endpoint-specification

Any chance you want to also add them as part of this PR?

I added a brief description of FleetAutoscaleRequestMetaData.
Should I also add a similar description to the Fleet manifest example and the Wasm Function docs?

@sugar-cat7 sugar-cat7 requested a review from markmandel December 3, 2025 16:32
The `FleetAutoscaleResponse`'s `Replica` field is used to set the target `Fleet` count with each sync interval, thereby
providing the autoscaling functionality.

{{< beta title="Fleet Metadata in Webhook Requests" gate="FleetAutoscaleRequestMetaData" >}}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to mention, will need to be feature short coded like so:

https://agones.dev/site/docs/contribute/documentation-editing-contribution/#within-a-page

1.54.0 just released, so the shortcode and version numbers in this PR will also need to be updated.

Thanks!

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’ve added the feature shortcode.
e9f4ba8

@sugar-cat7 sugar-cat7 requested a review from markmandel December 6, 2025 12:33
Copy link
Collaborator

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if the ticket captured everything in:

// To promote a feature from alpha->beta:
// * move from `false` to `true` in `featureDefaults`.
// * move from `false` to `true` in install/helm/agones/defaultfeaturegates.yaml
// * remove from `ALPHA_FEATURE_GATES` in build/Makefile
// * add to `BETA_FEATURE_GATES` in build/Makefile
// * invert in the e2e-runner config in cloudbuild.yaml
// * change the value in site/content/en/docs/Guides/feature-stages.md.
// * add it to test/upgrade/versionMap.yaml
// * Ensure that the features in each file are organized categorically and alphabetically.

So you also need to do:

agones/cloudbuild.yaml

Lines 309 to 311 in e2d3522

# Keep in sync with the inverse of 'alpha' and 'beta' features in
# pkg/util/runtime/features.go:featureDefaults
featureWithGate="PlayerAllocationFilter=true&FleetAutoscaleRequestMetaData=true&PlayerTracking=true&CountsAndLists=false&RollingUpdateFix=false&PortRanges=false&PortPolicyNone=false&ScheduledAutoscaler=false&GKEAutopilotExtendedDurationPods=false&SidecarContainers=true&WasmAutoscaler=true&Example=true"

But otherwise, this is looking good! Thanks!

Comment on lines 193 to 199
{{% feature publishVersion="1.54.0" %}}
{{< beta title="Fleet Metadata in Webhook Requests" gate="FleetAutoscaleRequestMetaData" >}}

When the `FleetAutoscaleRequestMetaData` feature gate is enabled by default, the Fleet's `labels` and
`annotations` are included in the `FleetAutoscaleRequest`, allowing webhooks to make scaling decisions based on
Fleet-specific metadata.
{{% /feature %}}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would bring things up to date for what is current, and also move it to beta with the next release 👍🏻

Suggested change
{{% feature publishVersion="1.54.0" %}}
{{< beta title="Fleet Metadata in Webhook Requests" gate="FleetAutoscaleRequestMetaData" >}}
When the `FleetAutoscaleRequestMetaData` feature gate is enabled by default, the Fleet's `labels` and
`annotations` are included in the `FleetAutoscaleRequest`, allowing webhooks to make scaling decisions based on
Fleet-specific metadata.
{{% /feature %}}
{{% feature expireyVersion="1.54.0" %}}
{{< alpha title="Fleet Metadata in Webhook Requests" gate="FleetAutoscaleRequestMetaData" >}}
{{% /feature %}}
{{% feature publishVersion="1.54.0" %}}
{{< beta title="Fleet Metadata in Webhook Requests" gate="FleetAutoscaleRequestMetaData" >}}
{{% /feature %}}
When the `FleetAutoscaleRequestMetaData` feature gate is enabled, the Fleet's `labels` and
`annotations` are included in the `FleetAutoscaleRequest`, allowing webhooks to make scaling decisions based on
Fleet-specific metadata.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I've made the changes.
dd07e26
2a9e4ef

@markmandel
Copy link
Collaborator

/gcbrun

@agones-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: 91dce7b4-711a-487f-9e5b-9c18ef0c586a

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4365/head:pr_4365 && git checkout pr_4365
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.54.0-dev-e9f4ba8

sugar-cat7 and others added 2 commits December 8, 2025 02:36
@sugar-cat7 sugar-cat7 requested a review from markmandel December 7, 2025 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/feature New features for Agones size/S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move FleetAutoscaleRequestMetaData to Beta

3 participants