-
Notifications
You must be signed in to change notification settings - Fork 868
feat: promote FleetAutoscaleRequestMetaData to beta #4365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: promote FleetAutoscaleRequestMetaData to beta #4365
Conversation
markmandel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the submission 🥳 , but I also noticed that we don't have any documentation on this feature in https://agones.dev/site/docs/reference/fleetautoscaler/#webhook-endpoint-specification
Any chance you want to also add them as part of this PR?
| | [Player Tracking]({{< ref "/docs/Guides/player-tracking.md" >}}) | `PlayerTracking` | Disabled | `Alpha` | 1.6.0 | | ||
| | [Scheduled Fleet Autoscaling](https://github.com/googleforgames/agones/issues/3008) | `ScheduledAutoscaler` | Enabled | `Beta` | 1.51.0 | | ||
| | [Extend Webhook autoscaler to send fleet metadata with the request](https://github.com/googleforgames/agones/issues/3951) | `FleetAutoscaleRequestMetaData` | Disabled | `Alpha` | 1.48.0 | | ||
| | [Extend Webhook autoscaler to send fleet metadata with the request](https://github.com/googleforgames/agones/issues/3951) | `FleetAutoscaleRequestMetaData` | Enabled | `Beta` | 1.48.0 | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same things as #4364 - this shouldn't be changed, since this is the current docs that are displayed, and the feature will only move in the next version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix
d707615
|
/gcbrun (not that I think there will be an issue) |
|
Build Failed 😭 Build Id: 16a61980-7824-430a-bf59-834c4fe8eef8 Status: FAILURE To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
I added a brief description of FleetAutoscaleRequestMetaData. |
| The `FleetAutoscaleResponse`'s `Replica` field is used to set the target `Fleet` count with each sync interval, thereby | ||
| providing the autoscaling functionality. | ||
|
|
||
| {{< beta title="Fleet Metadata in Webhook Requests" gate="FleetAutoscaleRequestMetaData" >}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Forgot to mention, will need to be feature short coded like so:
https://agones.dev/site/docs/contribute/documentation-editing-contribution/#within-a-page
1.54.0 just released, so the shortcode and version numbers in this PR will also need to be updated.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’ve added the feature shortcode.
e9f4ba8
markmandel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if the ticket captured everything in:
agones/pkg/util/runtime/features.go
Lines 113 to 121 in e2d3522
| // To promote a feature from alpha->beta: | |
| // * move from `false` to `true` in `featureDefaults`. | |
| // * move from `false` to `true` in install/helm/agones/defaultfeaturegates.yaml | |
| // * remove from `ALPHA_FEATURE_GATES` in build/Makefile | |
| // * add to `BETA_FEATURE_GATES` in build/Makefile | |
| // * invert in the e2e-runner config in cloudbuild.yaml | |
| // * change the value in site/content/en/docs/Guides/feature-stages.md. | |
| // * add it to test/upgrade/versionMap.yaml | |
| // * Ensure that the features in each file are organized categorically and alphabetically. |
So you also need to do:
Lines 309 to 311 in e2d3522
| # Keep in sync with the inverse of 'alpha' and 'beta' features in | |
| # pkg/util/runtime/features.go:featureDefaults | |
| featureWithGate="PlayerAllocationFilter=true&FleetAutoscaleRequestMetaData=true&PlayerTracking=true&CountsAndLists=false&RollingUpdateFix=false&PortRanges=false&PortPolicyNone=false&ScheduledAutoscaler=false&GKEAutopilotExtendedDurationPods=false&SidecarContainers=true&WasmAutoscaler=true&Example=true" |
But otherwise, this is looking good! Thanks!
| {{% feature publishVersion="1.54.0" %}} | ||
| {{< beta title="Fleet Metadata in Webhook Requests" gate="FleetAutoscaleRequestMetaData" >}} | ||
|
|
||
| When the `FleetAutoscaleRequestMetaData` feature gate is enabled by default, the Fleet's `labels` and | ||
| `annotations` are included in the `FleetAutoscaleRequest`, allowing webhooks to make scaling decisions based on | ||
| Fleet-specific metadata. | ||
| {{% /feature %}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would bring things up to date for what is current, and also move it to beta with the next release 👍🏻
| {{% feature publishVersion="1.54.0" %}} | |
| {{< beta title="Fleet Metadata in Webhook Requests" gate="FleetAutoscaleRequestMetaData" >}} | |
| When the `FleetAutoscaleRequestMetaData` feature gate is enabled by default, the Fleet's `labels` and | |
| `annotations` are included in the `FleetAutoscaleRequest`, allowing webhooks to make scaling decisions based on | |
| Fleet-specific metadata. | |
| {{% /feature %}} | |
| {{% feature expireyVersion="1.54.0" %}} | |
| {{< alpha title="Fleet Metadata in Webhook Requests" gate="FleetAutoscaleRequestMetaData" >}} | |
| {{% /feature %}} | |
| {{% feature publishVersion="1.54.0" %}} | |
| {{< beta title="Fleet Metadata in Webhook Requests" gate="FleetAutoscaleRequestMetaData" >}} | |
| {{% /feature %}} | |
| When the `FleetAutoscaleRequestMetaData` feature gate is enabled, the Fleet's `labels` and | |
| `annotations` are included in the `FleetAutoscaleRequest`, allowing webhooks to make scaling decisions based on | |
| Fleet-specific metadata. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
/gcbrun |
|
Build Succeeded 🥳 Build Id: 91dce7b4-711a-487f-9e5b-9c18ef0c586a The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version: |
Co-authored-by: Mark Mandel <[email protected]>
What type of PR is this?
/kind feature
What this PR does / Why we need it:
promote FleetAutoscaleRequestMetaData to beta
Which issue(s) this PR fixes:
Closes #4360
Special notes for your reviewer: