Conversation
Added the `ObjectContexts` and `ObjectCustomContextPayload` classes to represent user-defined object contexts, analogous to Java's `ObjectContexts`. Added `contexts` getter and setter to `Blob` class which automatically formats and parses dictionaries to the expected API representation. Integrated the corresponding system and unit tests. Co-authored-by: nidhiii-27 <224584462+nidhiii-27@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the Google Cloud Storage Python client by adding support for Object Contexts on Blob objects. This feature provides a structured and strongly-typed mechanism for associating custom, arbitrary data with objects, bringing the Python client's capabilities in line with other language clients like Java. The changes involve defining new data structures for contexts and integrating them seamlessly into the existing Blob API for easy management. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces the Object Contexts feature, which is a great addition for parity with the Java client. The implementation looks solid, with new classes for ObjectContexts and ObjectCustomContextPayload, and the necessary integration into the Blob object. The tests are also comprehensive, covering both unit and system-level verification.
I have a couple of suggestions to improve code maintainability by reducing some code duplication and simplifying logic, and ensuring proper handling of mutable dictionary parameters. Overall, this is a well-executed feature.
Added the strongly-typed `ObjectContexts` and `ObjectCustomContextPayload` schema classes to interact with the new `contexts` field on Google Cloud Storage `Blob` objects. Integrated these changes as a property on the `Blob` class which automatically resolves updates and patches for dictionaries mapping configurations to explicit subclasses. Added system and unit tests mimicking existing configurations. Co-authored-by: nidhiii-27 <224584462+nidhiii-27@users.noreply.github.com>
This PR adds the Object Contexts feature, implementing strongly-typed payloads for arbitrary context configuration mimicking the Java storage client's implementation.
google/cloud/storage/contexts.pyspecifying the schema forObjectContextsandObjectCustomContextPayload.contextsproperty onBlobobjects which performs mapping to underlying properties for patching.PR created automatically by Jules for task 1046589087761828711 started by @nidhiii-27