-
Notifications
You must be signed in to change notification settings - Fork 1.6k
chore: fix import replacements in scripts #15503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @ohmayr, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the internal configuration files responsible for post-processing generated client library code. The changes are necessary to align with recent modifications in the Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates several YAML configuration files used for post-processing generated client code. The changes adapt the find-and-replace rules to a new import style (import ... as ... instead of from ... import ...) presumably now used by the gapic-generator. The modifications are consistent across all files and correctly reflect this change. I've pointed out a minor issue in one of the files where literal \n characters are used within YAML literal blocks, which is likely incorrect, and have suggested removing them.
| ] | ||
| before: | | ||
| from google.iam.v1 import policy_pb2 # type: ignore\n | ||
| import google.iam.v1.policy_pb2 as policy_pb2 # type: ignore\n |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The explicit \n at the end of this line is likely unnecessary. In a YAML literal block (|), newlines are already preserved. This will cause the replacement tool to search for a line ending with the literal characters \ and n before the newline, which is probably not the intention.
import google.iam.v1.policy_pb2 as policy_pb2 # type: ignore| from google.iam.v1 import policy_pb2 # type: ignore | ||
| import google.iam.v1.policy_pb2 as policy_pb2 # type: ignore | ||
| from grafeas import grafeas_v1 | ||
| from grafeas.grafeas_v1.services.grafeas import transports\n |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update scripts to be compatible with the latest changes in gapic-generator to generate import statements.