chore: Migrate gsutil usage to gcloud storage #15497
Conversation
Summary of ChangesHello @gurusai-voleti, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request systematically transitions existing references and usage from the legacy Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request automates the migration from gsutil to gcloud storage by updating references in comments and documentation. The changes in .kokoro/trampoline_v2.sh and google/cloud/asset_v1p2beta1/types/asset_service.py are correct. However, I've identified a potential point of confusion in google/cloud/devtools/cloudbuild_v1/types/cloudbuild.py, where an enum member GSUTIL is now described as using gcloud storage. This makes the name misleading. I've added a comment to suggest improving the documentation for API clarity.
| GSUTIL (1): | ||
| Use the "gsutil" tool to download the source | ||
| Use the "gcloud storage" tool to download the source | ||
| file. |
There was a problem hiding this comment.
The enum member is named GSUTIL, but its description has been updated to say it uses gcloud storage. This creates a discrepancy that could be confusing for developers using this API, as the name GSUTIL strongly implies the use of the gsutil tool.
To improve clarity, please consider one of the following:
- Update the description to acknowledge the legacy name, for example:
Use the "gcloud storage" tool to download the source file. This option is the successor to the legacy "gsutil" tool functionality. - If this is a significant behavior change, it might be better to introduce a new enum member and deprecate
GSUTILto avoid breaking changes while guiding users to the new option.
This will help make the API less ambiguous.
There was a problem hiding this comment.
This is automatically generated via a pipeline from internal protos, so please contact the API team to make a change about a new default value like DOWNLOAD or GCLOUD; and a comment change about GSUTIL now being a deprecated enum value that acts like the new default, which should be backwards-compatible.
| uri (str): | ||
| The URI of the Cloud Storage object. It's the same URI that | ||
| is used by gsutil. For example: | ||
| is used by gcloud storage. For example: |
There was a problem hiding this comment.
This is automatically generated via a pipeline from internal protos, so please contact the API team to make comment changes and propagate them through.
| GSUTIL (1): | ||
| Use the "gsutil" tool to download the source | ||
| Use the "gcloud storage" tool to download the source | ||
| file. |
There was a problem hiding this comment.
This is automatically generated via a pipeline from internal protos, so please contact the API team to make a change about a new default value like DOWNLOAD or GCLOUD; and a comment change about GSUTIL now being a deprecated enum value that acts like the new default, which should be backwards-compatible.
2 participants
Automated: Migrate {target_path} from gsutil to gcloud storage
This CL is part of the on going effort to migrate from the legacy
gsutiltool to the new and improvedgcloud storagecommand-line interface.gcloud storageis the recommended and modern tool for interacting with Google Cloud Storage, offering better performance, unified authentication, and a more consistent command structure with othergcloudcomponents. 🚀Automation Details
This change was generated automatically by an agent that targets users of
gsutil.The transformations applied are based on the gsutil to gcloud storage migration guide.
While we have based the automation on the migration guide, every use case is unique.
It is crucial that you thoroughly test these changes in environments appropriate to your use-case before merging.
Be aware of potential differences between
gsutilandgcloud storagethat could impact your workflows.For instance, the structure of command output may have changed, requiring updates to any scripts that parse it. Similarly, command behavior can differ subtly; the
gcloud storage rsynccommand has a different file deletion logic thangsutil rsync, which could lead to unintended file deletions.Our migration guides can help guide you through a list of mappings and some notable differences between the two tools.
Standard presubmit tests are run as part of this CL's workflow. If you need to target an additional test workflow or require assistance with testing, please let us know.
Please verify that all your Cloud Storage operations continue to work as expected to avoid any potential disruptions in production.
Support and Collaboration
The
GCS CLIteam is here to help! If you encounter any issues, have a complex use case that this automated change doesn't cover, or face any other blockers, please don't hesitate to reach out.We are happy to work with you to test and adjust these changes as needed.
Contact:
[email protected]We appreciate your partnership in this important migration effort!
#gsutil-migration