docs: move PBKDF2 example to a separate file (#283) - #345
Open
bhavit04 wants to merge 1 commit into
Open
Conversation
Moves the Pbkdf2SecretKey example out of the doc comment into
example/webcrypto/pbkdf2/derive_bits.dart and references it with
{@example}, like the HMAC one. Also fixes bugs the move surfaced:
utf8.decode should be utf8.encode for the password and salt, and
deriveBits is an instance method so it's called on the key.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #283, one primitive per PR. Moves the
Pbkdf2SecretKeyexample out of the doc comment intoexample/webcrypto/pbkdf2/derive_bits.dartand references it with{@example}, same as the HMAC one.Moving it to a real file surfaced a couple of bugs in the example that I fixed so it actually analyzes and runs:
utf8.decode(...)on the password and salt should beutf8.encode(...)(string to bytes, not the other way around)deriveBitsis an instance method, so it's now called on the importedkeyinstead of statically onPbkdf2SecretKeydart analyzeanddart formatboth pass on the new file.