fix(hmac): use block size for default key length - #343
Open
harrshita123 wants to merge 1 commit into
Open
Conversation
harrshita123
marked this pull request as ready for review
July 25, 2026 11:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The FFI backend used
EVP_MD_sizewhenlengthwas omitted. That function returns the digest size, while Web Crypto defines the default HMAC key length as the hash function's block size. This made native-generated keys shorter than browser-generated keys.Explicitly supplied key lengths continue to take precedence.
Validation
dart format --output none --set-exit-if-changed .dart analyze --fatal-warnings .dart test test/hmac_default_key_length_test.dart -p vmdart test test/hmac_default_key_length_test.dart -p chrome -c dart2js,dart2wasmdart test --exclude-tags browser-interop -p vmCloses #342