Enhance documentation for EcdhPublicKey imports - #319
Merged
Conversation
Added documentation for importing EcdhPublicKey from raw elliptic curve point and SPKI format.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
jonasfj
reviewed
Jul 15, 2026
Member
|
See also #283 |
Collaborator
|
LGTM after formatting fix. Moving to the standalone examples from #283 can also be done in a follow-up. |
HamdaanAliQuatil
approved these changes
Jul 24, 2026
Clarify the documentation for importing EcdhPublicKey by specifying the use of EC algorithm identifiers and point encoding.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds missing dartdoc examples for
EcdhPublicKeymethods, as part of #283.Changes:
importRawKey()importSpkiKey()(existing compatibility notes preserved)exportRawKey(), which previously had no doc comment at allAll examples follow the self-contained pattern (with imports and a runnable
main()) used elsewhere in the codebase, consistent with #281.