Merged
Conversation
Collaborator
|
Thanks for the PRs! I'll review them in the next few days. |
shaladdle
requested changes
Mar 25, 2026
Collaborator
shaladdle
left a comment
shaladdle
left a comment
There was a problem hiding this comment.
Thanks! Just some minor edits.
stepancheg
force-pushed
the
client-config
branch
2 times, most recently
from
eb55944 to
f360268
Compare
Contributor
Author
|
Rephrased. |
`max_in_flight_requests` parameter IMO is dangerously low. But for now try to explain the meaning of the parameter better. And add more explanations to another parameter while at it.
shaladdle
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
max_in_flight_requestsparameter IMO is dangerously low. But for now try to explain the meaning of the parameter better.And add more explanations to another parameter while at it.