Reset progressive accumulation when film dimensions, crop window, or … - #38
Merged
Merged
Conversation
…AOV bindings change
dvicini
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously,
reset_progressive_was only set when camera or scene prims were dirtied (SyncCamera, etc.), but not whenfilm_changed(buffer resize orcrop_windowchange) orSetAovBindingsoccurred without a camera frustum update (e.g., aspect-ratio-preserving / DPI resizes, resizing with a USD scene camera, or toggling AOVs). This causedaccum_buffer_.array() += result.array()to add tensors of different shapes and fail withjit_var_add: operands have incompatible sizes!.