Skip to content

Fix UninitializedPropertyAccessException #3542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andreia-ferreira wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix UninitializedPropertyAccessException #3542

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 6 additions & 16 deletions app/src/main/java/org/groundplatform/android/ui/datacollection/tasks/AbstractTaskFragment.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ import org.groundplatform.android.ui.datacollection.components.TaskFooter
import org.groundplatform.android.ui.datacollection.components.TaskView
import org.groundplatform.android.util.renderComposableDialog
import org.groundplatform.android.util.setComposableContent
import timber.log.Timber

abstract class AbstractTaskFragment<T : AbstractTaskViewModel> : AbstractFragment() {

Expand All @@ -53,21 +52,16 @@ abstract class AbstractTaskFragment<T : AbstractTaskViewModel> : AbstractFragmen
/** ID of the associated task in the Job. Used for instantiating the [viewModel]. */
var taskId by Delegates.notNull<String>()

protected val isViewModelInitialized: Boolean
get() =
try {
viewModel
true
} catch (e: UninitializedPropertyAccessException) {
Timber.e(e, "Viewmodel is not initialized")
false
}

override fun onCreate(savedInstanceState: Bundle?) {
super.onCreate(savedInstanceState)
if (savedInstanceState != null) {
taskId = requireNotNull(savedInstanceState.getString(TASK_ID))
}
@Suppress("UNCHECKED_CAST")
val vm =
dataCollectionViewModel.getTaskViewModel(taskId) as? T
?: error("ViewModel for taskId:$taskId not found.")
viewModel = vm
Comment on lines +60 to +64
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For conciseness, you can directly assign the result to viewModel instead of using an intermediate variable vm.

Suggested change
@Suppress("UNCHECKED_CAST")
val vm =
dataCollectionViewModel.getTaskViewModel(taskId) as? T
?: error("ViewModel for taskId:$taskId not found.")
viewModel = vm
@Suppress("UNCHECKED_CAST")
viewModel =
dataCollectionViewModel.getTaskViewModel(taskId) as? T
?: error("ViewModel for taskId:$taskId not found.")

}

override fun onSaveInstanceState(outState: Bundle) {
Expand All @@ -88,10 +82,6 @@ abstract class AbstractTaskFragment<T : AbstractTaskViewModel> : AbstractFragmen
override fun onViewCreated(view: View, savedInstanceState: Bundle?) {
super.onViewCreated(view, savedInstanceState)
view.doOnAttach {
@Suppress("UNCHECKED_CAST", "LabeledExpression")
val vm = dataCollectionViewModel.getTaskViewModel(taskId) as? T ?: return@doOnAttach

viewModel = vm
taskView.bind(this, viewModel)
taskView.addTaskView(onCreateTaskBody(layoutInflater))

Expand All @@ -104,7 +94,7 @@ abstract class AbstractTaskFragment<T : AbstractTaskViewModel> : AbstractFragmen

override fun onResume() {
super.onResume()
if (isViewModelInitialized) onTaskResume()
onTaskResume()
}

/** Creates the view for common task template with/without header. */
Expand Down
Loading