This repository was archived by the owner on Jun 8, 2026. It is now read-only.
collector: limit request body size to prevent OOM#369
Open
johanr-8 wants to merge 1 commit into
Open
Conversation
bsiegert
approved these changes
Apr 2, 2026
bsiegert
reviewed
Apr 2, 2026
|
|
||
| import ( | ||
| "encoding/json" | ||
| "io/ioutil" |
Contributor
There was a problem hiding this comment.
You need to add an import for "io". Ideally, run goimports.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The collector handler reads the entire POST body using ioutil.ReadAll
with no size limit. An attacker can send an arbitrarily large body to
exhaust server memory and crash the server with a single unauthenticated
POST request.
Fix: wrap the body reader with io.LimitReader before reading,
capping input at 1MB which is well above any legitimate CSP or
Reporting API payload size.