Only flag lambda types in FUNCTIONAL_INTERFACE_TYPES_TO_CHECK, but keep the underscore suggestion if it is.
#5458
+36
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…keep the underscore suggestion if it is. I don't think we want to flag other functional interface types in this check at all, given it shows on unchanged lines. Maybe UnnamedVariable could look for really obviously unused lambda parameters, and suggest it there? PiperOrigin-RevId: 859520919
copybara-service
bot
force-pushed
the
test_859252539
branch
from
b15821a to
2a85583
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only flag lambda types in
FUNCTIONAL_INTERFACE_TYPES_TO_CHECK, but keep the underscore suggestion if it is.I don't think we want to flag other functional interface types in this check at all, given it shows on unchanged lines. Maybe UnnamedVariable could look for really obviously unused lambda parameters, and suggest it there?