Restructure template specialization to introduce Tuples.#1067
Merged
Conversation
copybara-service
Bot
force-pushed
the
test_919181519
branch
6 times, most recently
from
0d0ae0f to
2f63bb3
Compare
Tuples break the previous status quo since they are not enums and not ADTs. Introducing template specializations for them requires a slew of changes across the codebase to accomodate these differences. This CL contains all of those changes, but none of the actual Tuple functionality. In it's place an inert `rs_std::Tuple` is emitted that can't do anything yet. A followup CL fleshes out the actual API with functionality. PiperOrigin-RevId: 919936517
copybara-service
Bot
force-pushed
the
test_919181519
branch
from
2f63bb3 to
d64cca0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restructure template specialization to introduce Tuples.
Tuples break the previous status quo since they are not enums and not
ADTs. Introducing template specializations for them requires a slew of
changes across the codebase to accomodate these differences. This CL
contains all of those changes, but none of the actual Tuple
functionality. In it's place an inert
rs_std::Tupleis emitted thatcan't do anything yet. A followup CL fleshes out the actual API with
functionality.