Skip to content

Conversation

@jagghoshal-blip
Copy link
Collaborator

  • Add directory existence check during caching
  • The ConstructCachePaths function now returns a Result and handles the creation of all required directories, including the build cache and the parent directories for target artifacts. This centralizes directory management within the path construction logic.
  • Add cache hit/miss logging

Bug: 441779367

- Add directory existence checks for target artifact paths.
- The `ConstructCachePaths` function now returns a `Result` and handles the creation of all required directories, including the build cache and the parent directories for target artifacts. This centralizes directory management within the path construction logic.
- Add cache hits/misses logging
- Add directory existence check during caching
- The `ConstructCachePaths` function now returns a `Result` and handles the creation of all required directories, including the build cache and the parent directories for target artifacts. This centralizes directory management within the path construction logic.
- Add cache hit/miss logging

Bug: 441779367
@cjreynol
Copy link
Collaborator

I think you meant to have the target be main. Also, was there a reason to not push this extra commit to #2040 and continue with that PR?

@jagghoshal-blip
Copy link
Collaborator Author

I think you meant to have the target be main. Also, was there a reason to not push this extra commit to #2040 and continue with that PR?

That was my initial attempt and it said I cannot publish the commit to this protected branch of mine, so I created cf_signed_1. 9bb0f4135 is the right HEAD commit for this change.

@Databean Databean changed the base branch from jagghoshal-blip-patch-1 to main January 22, 2026 19:16
@Databean Databean added the kokoro:run Run e2e tests. label Jan 22, 2026
@GoogleCuttlefishTesterBot GoogleCuttlefishTesterBot removed the kokoro:run Run e2e tests. label Jan 22, 2026
@Databean
Copy link
Member

Databean commented Jan 22, 2026

I think the confusion came from creating branches on the upstream github.com/google/android-cuttlefish repository. Normally the workflow is that every developer has their own fork (mine is github.com/Databean/android-cuttlefish) where they create new branches, and pull requests are made from the forked repository branches to the upstream main branch.

I've retargeted the pull request to reference main.

@jagghoshal-blip
Copy link
Collaborator Author

I think the confusion came from creating branches on the upstream github.com/google/android-cuttlefish repository. Normally the workflow is that every developer has their own fork (mine is github.com/Databean/android-cuttlefish) where they create new branches, and pull requests are made from the forked repository branches to the upstream main branch.

I've retargeted the pull request to reference main.

Thats it! This is the issue I created for myself. I should have used the jagghoshal-blip/android-cuttlefish repo. Thanks for the help!

@Databean Databean added this pull request to the merge queue Jan 22, 2026
Merged via the queue into main with commit 5b5de69 Jan 22, 2026
45 of 46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants