Add initial flag metrics gathering #2043
Open
+122
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjreynol
force-pushed
the
initial_metrics_flags
branch
2 times, most recently
from
f6024da to
5faef0e
Compare
This commit does not gather any data, but implements moving the data around. Bug: 476236433
Not yet converted for transmission, but `cpus` and `daemon` flag data are available at that stage. Bug: 476236433
Utilize the data gathered in the previous commit and populate the proto with it for transmission. Bug: 476236433
cjreynol
force-pushed
the
initial_metrics_flags
branch
from
5faef0e to
7ed65fe
Compare
cjreynol
added
kokoro:force-run
GoogleCuttlefishTesterBot
removed
kokoro:run
Databean
approved these changes
Jan 22, 2026
| bool daemon; | ||
| }; | ||
|
|
||
| Result<std::vector<FlagMetrics>> GetFlagMetrics(const int guest_count); |
Member
There was a problem hiding this comment.
const isn't meaningful in this declaration the way it is in the function definition.
See https://abseil.io/tips/109
Please remove it here.
| bool daemon; | ||
| }; | ||
|
|
||
| Result<std::vector<FlagMetrics>> GetFlagMetrics(const int guest_count); |
Member
There was a problem hiding this comment.
Please document that this function relies on gflags::ParseCommandLineFlags being called.
It's relatively more explicit in some of the names like FromGlobalGflags, but not as explicit here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets up the necessary structure for gathering more flags, and gathers some initial fields. Will be expanded in future PRs.
Bug: 476236433
Bug: 463432559