[small-business-loan-agent] simplify for deployment in agent garden #1425
Closed
norarfilali wants to merge 6 commits intomainfrom
Closed
[small-business-loan-agent] simplify for deployment in agent garden #1425norarfilali wants to merge 6 commits intomainfrom
norarfilali wants to merge 6 commits intomainfrom
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
📋 Review Summary
This PR simplifies the deployment process for the small-business-loan-agent, specifically targeting Gemini Enterprise (AgentSpace) and Agent Engine. It introduces a custom Gemini model class to handle specific location requirements, hardcodes database names for easier setup, and adds a GCS fallback for file uploads in restricted environments.
🔍 General Feedback
- The move towards opinionated defaults (hardcoded DB names) aligns with the goal of 1-click deployment.
- The artifact loading logic is robust, handling multiple formats.
- The GCS fallback is a great addition for testing in the Agent Engine Playground.
- Minor typos and some hardcoded values that could be slightly more flexible were identified.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Signed-off-by: Nora Filali <norafilali@google.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Signed-off-by: Nora Filali <norafilali@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-support deployment in Gemini Enterprise