Skip to content

feat: add the implementation of Eventarc subrouter#713

Merged
anFatum merged 6 commits intogoogle:mainfrom
anFatum:eventarc-subrouter
Apr 13, 2026
Merged

feat: add the implementation of Eventarc subrouter#713
anFatum merged 6 commits intogoogle:mainfrom
anFatum:eventarc-subrouter

Conversation

@anFatum
Copy link
Copy Markdown
Contributor

@anFatum anFatum commented Apr 8, 2026

Implementation of Cloud Events trigger processing.

This implementation should handle the resource exhausted exceptions with jitter to prevent thundering herd (configured per subrouter).

Similar to #704

(see the details in go/orcas-rfc-522)

@anFatum anFatum requested review from dpasiukevich and kdroste-google and removed request for baptmont April 10, 2026 10:37
Comment thread server/adkrest/controllers/triggers/eventarc.go Outdated
Comment thread server/adkrest/controllers/triggers/pubsub.go Outdated
Comment thread server/adkrest/controllers/triggers/pubsub.go Outdated
Comment thread server/adkrest/controllers/triggers/pubsub.go
@anFatum anFatum requested a review from kdroste-google April 13, 2026 08:41
kdroste-google
kdroste-google previously approved these changes Apr 13, 2026
Copy link
Copy Markdown
Collaborator

@kdroste-google kdroste-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add debugging info (indicated in comments)

Comment thread server/adkrest/controllers/triggers/pubsub.go
Comment thread server/adkrest/controllers/triggers/eventarc.go Outdated
Comment thread server/adkrest/controllers/triggers/eventarc.go Outdated
Copy link
Copy Markdown
Collaborator

@kdroste-google kdroste-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@anFatum anFatum merged commit a37ce95 into google:main Apr 13, 2026
4 checks passed
kdroste-google pushed a commit to kdroste-google/adk-go that referenced this pull request Apr 13, 2026
Implementation of Cloud Events trigger processing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants