fix(session/vertexai): populate FunctionCall and FunctionResponse IDs…#690
Open
ravyg wants to merge 2 commits intogoogle:mainfrom
Open
fix(session/vertexai): populate FunctionCall and FunctionResponse IDs…#690ravyg wants to merge 2 commits intogoogle:mainfrom
ravyg wants to merge 2 commits intogoogle:mainfrom
Conversation
… during deserialization The aiplatformToGenaiContent function was not copying the Id field from FunctionCall and FunctionResponse protobuf parts, even though createAiplatformpbContent correctly serializes them. This caused function response events to be silently dropped in multi-invocation sessions, as the matching logic relies on non-empty IDs. Fixes google#679
Author
|
Hi @indurireddy-TF — I saw you self-assigned #679. Just a heads-up that this PR (#690, opened Mar 28) already implements the fix you described in your comment there: it populates Would you be able to take a look, or point me to the right reviewer? Happy to adjust the diff — smaller scope, different test layout, or anything else — if that'd help get it over the line. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
aiplatformToGenaiContentfunction was not copying theIdfieldfrom
FunctionCallandFunctionResponseprotobuf parts duringdeserialization, even though
createAiplatformpbContentcorrectlyserializes them. This caused function response events to be silently
dropped in multi-invocation sessions with tool calls, as the matching
logic relies on non-empty IDs.
Added a unit test for the round-trip to prevent regression.
Fixes #679