chore(cleanup): Cleanup basic_function.ts#1073
Merged
gspencergoog merged 1 commit intogoogle:mainfrom Apr 8, 2026
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds JSDoc documentation to various function implementations in basic_functions.ts and refines the type casting in the PluralizeImplementation. Review feedback identifies a misleading JSDoc claim regarding URL sanitization in OpenUrlImplementation and suggests using nullish coalescing in PluralizeImplementation to correctly handle empty string values.
renderers/web_core/src/v0_9/basic_catalog/functions/basic_functions.ts
Outdated
Show resolved
Hide resolved
renderers/web_core/src/v0_9/basic_catalog/functions/basic_functions.ts
Outdated
Show resolved
Hide resolved
gspencergoog
force-pushed
the
cleanup_functions
branch
from
1958882 to
f20f734
Compare
gspencergoog
force-pushed
the
cleanup_functions
branch
from
f20f734 to
89f3c32
Compare
jacobsimionato
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Some small cleanups to basic_functions.ts: adding JSDoc comments to exports, and fixing a cast to "any".