A minor fix is included in weatherbenchX's interpolation to handle conflicting coordinates when trying to evaluate gridded head predictions against hold-out stations. - #237
Open
copybara-service[bot] wants to merge 1 commit into
Conversation
…nflicting coordinates when trying to evaluate gridded head predictions against hold-out stations. PiperOrigin-RevId: 940714413
sylvesterkaczmarek
left a comment
sylvesterkaczmarek
left a comment
There was a problem hiding this comment.
The new station test uses a time coordinate, but select_bin_thresholds_by_time_from_chunk() only checks valid_time (or init_time/lead_time). That input falls through and returns the full threshold array unchanged, so the added [2, 3] expectation cannot pass. Should time be handled as the valid-time coordinate here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A minor fix is included in weatherbenchX's interpolation to handle conflicting coordinates when trying to evaluate gridded head predictions against hold-out stations.