Camera looking strange when moving drastically#238
Open
MrXandbadas wants to merge 13 commits intogoogle-research:mainfrom
Open
Camera looking strange when moving drastically#238MrXandbadas wants to merge 13 commits intogoogle-research:mainfrom
MrXandbadas wants to merge 13 commits intogoogle-research:mainfrom
Conversation
Added the spot_blend and spot_size parameters into the lights.py file. Spot Blend is the roughness of the beam Spot Size is the radius in deg 0 - 180 Blender.py was changed to add the needed parameters inside the blender handler. I think I added the correct identifiers and what not. I just copied the standard implementation as it was written. The SpotLight was added in with the other forms of Lights ---------- Still need to look at the colors of the lights. Maybe refer to the issue in the main github of Kubric regarding the Color Class and its implementation.
Awesome notes from Qwlouse! can be found at PR google-research#219
As per google-research#225 fix implemented
updateeeee
Co-authored-by: Klaus Greff <klausg@google.com>
Bug Fix noted by Qwlouse
An attempt to help with google-research#197 google-research#198 Created a new function in Kubric core. set_position() I hope this is helpful xD
Codecov Report
@@ Coverage Diff @@
## main #238 +/- ##
=======================================
- Coverage 61.8% 61.8% -0.1%
=======================================
Files 42 42
Lines 3514 3519 +5
=======================================
+ Hits 2173 2175 +2
- Misses 1341 1344 +3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This reverts commit 071360d.
Collaborator
|
This is changing the behavior of the camera, by always locking it onto a target. While I agree that this is a useful feature I don't think this should be the default, and in any case it should be possible to disable. So for now I would recommend to re-set the look_at manually after moving the camera. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I made a hot fix. it Is not a Fix... But it's a workaround?