Skip to content

Improve compile time #2381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
copybara-service wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Improve compile time #2381

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions torax/_src/fvm/newton_raphson_solve_block.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,9 +242,7 @@ def newton_raphson_solve_block(
tau_min=tau_min,
log_iterations=log_iterations,
)
root_finder = jax_utils.xla_metadata_call(
jax.jit(root_finder), compilation_unit='newton_raphson_root_finder'
)
root_finder = jax.jit(root_finder, inline=jax.Inline.XLA_LATE)

x_root, metadata = root_finder(x0=init_x_new_vec)

Expand Down
10 changes: 2 additions & 8 deletions torax/_src/solver/jax_root_finding.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,17 +85,11 @@ def root_newton_raphson(

def _newton_raphson(f, x, jacobian_fun=None):
init_x_new_vec = x
f = jax.jit(f)

residual_fun = jax_utils.xla_metadata_call(
f, compilation_unit='residual_fun_block'
)
residual_fun = f

if jacobian_fun is None:
jacobian_fun = jax.jacfwd(f)
jacobian_fun = jax_utils.xla_metadata_call(
jax.jit(jacobian_fun), compilation_unit='jacobian_fun_block'
)
jacobian_fun = jax.jit(jacobian_fun, inline=jax.Inline.XLA_LATE)

# initialize state dict being passed around Newton-Raphson iterations
residual_vec_init_x_new = residual_fun(init_x_new_vec)
Expand Down
Loading