Split the Solver class into prepare_step and solve_step. - #2354
Open
copybara-service[bot] wants to merge 1 commit into
Open
Split the Solver class into prepare_step and solve_step. #2354copybara-service[bot] wants to merge 1 commit into
Solver class into prepare_step and solve_step. #2354copybara-service[bot] wants to merge 1 commit into
Conversation
copybara-service
Bot
force-pushed
the
test_962100892
branch
3 times, most recently
from
September 8, 2026 09:28
fd7039e to
7499c73
Compare
Previously, the adaptive time-step backtracking ran the entire solver for each attempt. This meant time-step independent computations (like calculating coefficients at time t using QLKNN) were repeated redundantly. PiperOrigin-RevId: 962100892
copybara-service
Bot
force-pushed
the
test_962100892
branch
from
September 8, 2026 09:57
7499c73 to
30d8f39
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split the
Solverclass intoprepare_stepandsolve_step.Previously, the adaptive time-step backtracking ran the entire solver for each attempt. This meant time-step independent computations (like calculating coefficients at time t using QLKNN) were repeated redundantly.