fix: allow non-string AxisNames in check_structure (issue #132)#138
Open
Nas01010101 wants to merge 1 commit into
Open
fix: allow non-string AxisNames in check_structure (issue #132)#138Nas01010101 wants to merge 1 commit into
Nas01010101 wants to merge 1 commit into
Conversation
…mind#132) AxisName is defined as Hashable (named_axes.py), so any hashable is a valid axis name. TmpPosAxisMarker instances are commonly used as non-string batch axis names. Two assertions in shapecheck.py incorrectly restricted axis keys to strings only: - _named_inline_multidimvars(): assert isinstance(subkey, str) - final solution verification: assert isinstance(name[1], str) Both assertions precede code that only performs dict operations (hashable-compatible), so removing them is safe. Also update the DimVar.name and KnownDim.name type annotations to use AxisName instead of str | int. Adds regression tests covering: - check_structure with known_vars containing non-string MultiDimVar keys - Linear layer called with a TmpPosAxisMarker batch axis (exact repro)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AxisName is defined as Hashable (named_axes.py), so any hashable is a valid axis name. TmpPosAxisMarker instances are commonly used as non-string batch axis names.
Two assertions in shapecheck.py incorrectly restricted axis keys to strings only:
Both assertions precede code that only performs dict operations (hashable-compatible), so removing them is safe. Also update the DimVar.name and KnownDim.name type annotations to use AxisName instead of str | int.
Adds regression tests covering: