Fix masking in label smoothing - #1760
Open
tandede wants to merge 1 commit into
Open
Conversation
tandede
marked this pull request as ready for review
August 20, 2026 06:33
Author
|
Hi maintainers, I’m following up on this PR in case it was missed. The CLA, security scans, linting, type checks, doctests, and Python/JAX test matrix have all passed. The label-smoothing masking fix is ready for review, and I’d be happy to address any feedback. Thank you! |
tandede
force-pushed
the
fix/masked-label-smoothing
branch
from
August 31, 2026 02:56
d29ff94 to
9ae27d9
Compare
Author
|
I rebased this branch onto the latest I reran the full Optax test suite locally: 2,617 passed, 78 skipped, with 3,382 subtests passed. Pre-commit, Ruff, Pyrefly, and |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan