fix: prevent division by zero in SAM gradient normalization - #1743
Open
wahid18-maqs wants to merge 1 commit into
Open
fix: prevent division by zero in SAM gradient normalization#1743wahid18-maqs wants to merge 1 commit into
wahid18-maqs wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves the numerical stability of
normalize()in the SAM optimizer by preventing division by zero when the gradient norm is zero.Changes
epsparameter to the gradient normalization step.g_norm + epsinstead ofg_norm.This change preserves the existing behavior for non-zero gradients while avoiding NaN propagation in zero-gradient scenarios, such as at convergence or after aggressive gradient clipping.