Skip to content

Conversation

@miguelvelasquezdev
Copy link

Implements a standalone TypeScript sample with Genkit and @a2a-js/sdk.

Includes ShoppingAgent, CredentialsProviderAgent, MerchantAgent, and MerchantPaymentProcessorAgent with full payment workflow support.

Description

Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

Closes #67 🦕

@miguelvelasquezdev miguelvelasquezdev requested a review from a team as a code owner January 22, 2026 03:16
@google-cla
Copy link

google-cla bot commented Jan 22, 2026

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @miguelvelasquezdev, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request delivers a new, self-contained TypeScript sample that showcases a complete agent-to-agent payment flow. It integrates multiple AI agents, each responsible for a specific part of the commerce transaction, from a shopper's initial product search to the final payment processing, demonstrating how these agents collaborate to fulfill a user's request.

Highlights

  • New TypeScript Sample: Introduces a comprehensive standalone TypeScript sample demonstrating an end-to-end payment workflow using Genkit and the @a2a-js/sdk.
  • Agent Implementation: Includes implementations for a ShoppingAgent, CredentialsProviderAgent, MerchantAgent, and MerchantPaymentProcessorAgent, all working together to simulate a full payment process.
  • Payment Workflow Support: The sample provides full support for a payment workflow, covering aspects from product search and cart management to shipping address collection, payment method selection, and payment processing, including handling OTP challenges.
  • CLI for Interaction: A command-line interface (CLI) is included to easily interact with the various agents and observe the workflow.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@miguelvelasquezdev miguelvelasquezdev force-pushed the feature/typescript-integration branch from 9c00d68 to 54d77e5 Compare January 22, 2026 03:20
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a comprehensive standalone TypeScript sample demonstrating the capabilities of Genkit and the @a2a-js/sdk for an e-commerce payment workflow. However, it contains critical security vulnerabilities, primarily related to Broken Access Control (IDOR) and LLM Safety (Prompt Injection), which could allow an attacker to steal sensitive user information. It is highly recommended to address these by implementing proper authentication/authorization and following LLM safety best practices. Additionally, several issues were identified, particularly with dependency versions in package.json, and suggestions for code improvements related to type safety, robustness, and best practices have been provided.

@miguelvelasquezdev miguelvelasquezdev force-pushed the feature/typescript-integration branch 20 times, most recently from 4849924 to dcd196c Compare January 25, 2026 14:42
Implements a standalone TypeScript sample with Genkit and @a2a-js/sdk.

Includes ShoppingAgent, CredentialsProviderAgent, MerchantAgent, and
MerchantPaymentProcessorAgent with full payment workflow support.

Closes google-agentic-commerce#67
@miguelvelasquezdev miguelvelasquezdev force-pushed the feature/typescript-integration branch from dcd196c to 805e0a8 Compare January 25, 2026 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feat]: Add TypeScript SDK & Samples for AP2 Mandates

1 participant