-
Notifications
You must be signed in to change notification settings - Fork 376
feat(typescript): introduce standalone sample #144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(typescript): introduce standalone sample #144
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Summary of ChangesHello @miguelvelasquezdev, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request delivers a new, self-contained TypeScript sample that showcases a complete agent-to-agent payment flow. It integrates multiple AI agents, each responsible for a specific part of the commerce transaction, from a shopper's initial product search to the final payment processing, demonstrating how these agents collaborate to fulfill a user's request. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
9c00d68 to
54d77e5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a comprehensive standalone TypeScript sample demonstrating the capabilities of Genkit and the @a2a-js/sdk for an e-commerce payment workflow. However, it contains critical security vulnerabilities, primarily related to Broken Access Control (IDOR) and LLM Safety (Prompt Injection), which could allow an attacker to steal sensitive user information. It is highly recommended to address these by implementing proper authentication/authorization and following LLM safety best practices. Additionally, several issues were identified, particularly with dependency versions in package.json, and suggestions for code improvements related to type safety, robustness, and best practices have been provided.
samples/typescript/src/agents/credentials-provider-agent/tools.ts
Outdated
Show resolved
Hide resolved
...pescript/src/agents/merchant-payment-processor-agent/merchant_payment_processor_agent.prompt
Outdated
Show resolved
Hide resolved
samples/typescript/src/agents/credentials-provider-agent/account-manager.ts
Show resolved
Hide resolved
4849924 to
dcd196c
Compare
Implements a standalone TypeScript sample with Genkit and @a2a-js/sdk. Includes ShoppingAgent, CredentialsProviderAgent, MerchantAgent, and MerchantPaymentProcessorAgent with full payment workflow support. Closes google-agentic-commerce#67
dcd196c to
805e0a8
Compare
Implements a standalone TypeScript sample with Genkit and @a2a-js/sdk.
Includes ShoppingAgent, CredentialsProviderAgent, MerchantAgent, and MerchantPaymentProcessorAgent with full payment workflow support.
Description
Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
CONTRIBUTINGGuide.Closes #67 🦕