Conversation
JekSun97
changed the title
focus_aabbfocus_aabb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuation and fixing issues in #123411
Fixed an issue where the camera focus was not centered at the world origin (reported by @Calinou here).
I also forgot to skip nodes that were not instances of
Node3D; this caused the camera to point at an undefined location when a genericNodewas selected.Additionally, when centering the view, the camera now takes into account both visual nodes and
Node3Dnodes when they are selected together; previously, it focused only on visual nodes.