Conversation
Contributor
|
I was just about to make a proposal about this. |
| HashSet<int> selected_nodes; | ||
| Vector<String> unsupported_nodes_captions; | ||
|
|
||
| for (int i = 0; i < graph->get_child_count(); i++) { |
Member
There was a problem hiding this comment.
Can this use iterate_children?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #99404, adding one important UX improvement that speeds up node group creation significantly.
As always, this was a bit more sophisticated than anticipated.
Detailed changes:
Notes:
VisualShaderNodeGroupBasesince it's a relic from the past. Ideally the Expression node should be overhauled to use the same mechanisms for port management as node groups.AI Disclosure: AI was used as part of a review pass at the end; resulting changes were done manually or in the form of surgical instructions.