Add qualify/unqualify code action on constants #5185
+649
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
GearsDatapacks
left a comment
GearsDatapacks
left a comment
There was a problem hiding this comment.
Looks good! A couple notes inline
| find_position_of("None").nth_occurrence(2).to_selection(), | ||
| ); | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
Can we get tests for:
- Qualifying unqualified functions
- Qualifying unqualified constants
- Unqualifying a value in a constant also unqualifies references in functions
- Unqualifying a value in a function also unqualifies references in constants
Contributor
Author
|
Added record check, as well as more tests, lemme know if I missed something or did something not quite right 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5180.