Discard unused variable code action

[clr-cera]

This PR creates the code action to discarding an unused variable.

References Issue #4950

As suggested the code action is currently set as preferred.

[clr-cera]

Hi, I am having two problems with this pr!

First, is the code action always applied after formatting? When the variable is assigned through a pattern, the code action must also remove the ' as ' before the variable name, and I haven't figured out how to find this span.

Also, the tests for the code action are failing, although they produce the right result, how can I fix that?

[GearsDatapacks]

1. No, the user isn't guaranteed to have formatted their code before running a code action. What we usually do when a certain new piece of location information is required is to add it to the AST. However in this case, I should think it would be possible to remove the code from the end of the inner pattern to the end of the as pattern, both of which you should already have the locations for.
2. That's because we use snapshot testing! The way it works is that first you run the tests to generate the output, then you manually review it to determine whether it is correct or not (use cargo insta review). After that, the correct value is stored and the test will only fail if it differs from the accepted snapshot. See docs/compiler/README.md for more information

[clr-cera]

1. No, the user isn't guaranteed to have formatted their code before running a code action. What we usually do when a certain new piece of location information is required is to add it to the AST. However in this case, I should think it would be possible to remove the code from the end of the inner pattern to the end of the as pattern, both of which you should already have the locations for.

   2. That's because we use snapshot testing! The way it works is that first you run the tests to generate the output, then you manually review it to determine whether it is correct or not (use cargo insta review). After that, the correct value is stored and the test will only fail if it differs from the accepted snapshot. See docs/compiler/README.md for more information

Thank you! Now I understood the snapshot testing, and wow, it works so well!
I will try to find the locations in the AST

[clr-cera]

I couldn't find the assign pattern related to the unused variable warning, I tried to visit all assign patterns locations and check if the variable location start is inside, but this returned no patterns, and I did not think of any other way.

Is there a way to, given a location, find the location of a string before it?

I will try to fix it later, thanks for helping!

[lpil]

Hello! Are you still working on this one? :)

[clr-cera]

Hello! Are you still working on this one? :)

Hi!
Oh, I got very busy with uni and personal life by the past few months, and completely forgot! I'm sorry for not writing updates.

I don't think I will be able to work on this issue until next year due to some of my deadlines, and I believe I would need help, as I got stuck finding a way to remove the 'as' in the assign pattern and got nowhere.

If someone wants to solve this issue on another PR, or wants to continue from here, feel free to do so, and I'm here to explain what I've done or discuss it!

[lpil]

No worries @clr-cera ! Thank you again. I'll close this, and anyone looking at the linked PR in future can reference thisone.