-
Notifications
You must be signed in to change notification settings - Fork 8.7k
fix(powershell): ensure UTF-8 templates are written without BOM #2280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+91
−33
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
c80eacc
fix(powershell): strip BOM from templates and ensure No-BOM output
Nimraakram12 834c4a2
fix: address review feedback on encoding and naming for all ps scripts
Nimraakram12 7f84369
fix: address copilot feedback (encoding detection and variable naming)
Nimraakram12 6fb1b73
fix: remove duplicate comments in setup-plan.ps1
Nimraakram12 28f097e
test: verify spec.md is written without UTF-8 BOM
Nimraakram12 a9fd3f4
test: also verify BOM-free output under Windows PowerShell 5.1
Nimraakram12 fe37fe8
fix
Nimraakram12 2731b24
fix: resolve merge conflict with main, add TestDescriptionQuoting
Nimraakram12 80889e0
fix: resolve TestDescriptionQuoting string quoting conflict with main
Nimraakram12 e02afb6
test: restore PowerShell prefix-stripping parity test in TestGetFeatu…
Nimraakram12 feb79c5
fix: remove trailing whitespace from module docstring blank lines
Nimraakram12 0631b98
Potential fix for pull request finding
Nimraakram22 fbe36b7
test: seed ps_git_repo with BOM-prefixed template to exercise WriteAl…
Nimraakram12 ab49149
fix: remove duplicate ps_git_repo fixture, restore ext_ps_git_repo
Nimraakram12 8ffb4d4
fix: remove unrelated TestDescriptionQuoting and restore original tes…
Nimraakram12 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.