Stop adding management comments to workflows - #115
Merged
Conversation
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The implementation consistently removes comment injection while retaining and testing lockfile updates.
Review tier: Balanced
Findings: None
What changed in this PR
Stops adding management comments to workflows while preserving lockfile onboarding behavior.
Changes:
- Removes sentinel-comment generation and related tests.
- Keeps no-rewrite workflows eligible for lockfile updates.
- Removes generated headers from workflows and integration fixtures.
| File | Description |
|---|---|
test/integration/run.rb |
Removes headers from generated fixtures. |
internal/workflowfile/rewrite.go |
Removes sentinel helper. |
internal/workflowfile/rewrite_test.go |
Removes obsolete helper tests. |
internal/pin/plan.go |
Clarifies no-rewrite lockfile planning. |
internal/pin/commit.go |
Stops injecting workflow comments. |
internal/pin/commit_test.go |
Verifies workflows remain unchanged. |
cmd/gh-actions-lock/selfrepository_test.go |
Removes obsolete sentinel assertions. |
.github/workflows/test.yml |
Removes generated header. |
.github/workflows/release.yml |
Removes generated header. |
.github/workflows/dependency-review.yml |
Removes generated header. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
heavymachinery
approved these changes
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Onboarding a workflow should update its lockfile state without adding an ownership comment to the workflow file. Users have found this more annoying than helpful.
What