Rust: Include more calls in DB quality metrics #20954
Open
+217
−44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| private import internal.MethodCallExprImpl | ||
| import codeql.rust.elements.CallExprBase | ||
| import codeql.rust.elements.ArgList | ||
| import codeql.rust.elements.Attr |
Check warning
Code scanning / CodeQL
Redundant import Warning
hvitved
force-pushed
the
rust/stats-more-calls
branch
4 times, most recently
from
e9747ed to
66cff19
Compare
hvitved
force-pushed
the
rust/stats-more-calls
branch
2 times, most recently
from
2894356 to
e0048ec
Compare
hvitved
force-pushed
the
rust/stats-more-calls
branch
from
e0048ec to
57bca5c
Compare
Copilot finished reviewing on behalf of
hvitved
December 5, 2025 09:18
Contributor
There was a problem hiding this comment.
Pull request overview
This PR expands the scope of call resolution metrics in Rust to include calls to overloaded operators and indexers, beyond the previously tracked function and method calls. This provides more comprehensive database quality metrics.
Key Changes
- Extended
CallTargetStatsto track allInvocationExprinstances, not justCallExprandMethodCallExpr - Renamed consistency check from
multipleCallTargetstomultipleResolvedTargetsto reflect the broader scope - Excluded non-overloaded operations (which don't have resolvable targets) and dynamic call expressions from metrics
- Updated all test expectations to reflect the new metrics, particularly showing multiple resolutions for dereference operations (
*x)
Reviewed changes
Copilot reviewed 25 out of 25 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| rust/ql/src/queries/telemetry/DatabaseQuality.qll | Refactored call target statistics to include overloaded operations and indexers via RelevantInvocationExpr |
| rust/ql/lib/codeql/rust/internal/PathResolutionConsistency.qll | Renamed and broadened multipleCallTargets to multipleResolvedTargets with updated type signature |
| rust/ql/consistency-queries/PathResolutionConsistency.ql | Updated query predicate name to match library changes |
| rust/ql/test/.../PathResolutionConsistency.expected | Regenerated test expectations showing new detections, primarily dereference operations with multiple targets |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include calls to overloaded operators and calls to indexers in the metrics for call resolution rates, as well as the consistency check for multiple resolutions.
DCA shows, not surprisingly, large increases in missing call targets and path resolution inconsistencies, but it also shows a slight decrease in resolution rates.
One known source of multiple resolutions is dereference expressions
*x, wherexhas type&or&mut; since type inference does not yet distinguish the two, we dispatch to both https://doc.rust-lang.org/std/ops/trait.Deref.html#impl-Deref-for-%26T and https://doc.rust-lang.org/std/ops/trait.Deref.html#impl-Deref-for-%26mut+T.