Copilot: Remove the formatting instructions, as they're confusing CCR. #20128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aschackmull
added
the
no-change-note-required
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes confusing formatting instructions for CodeQL files from the Copilot instructions to improve code review behavior. The formatting instructions were causing conflicts with existing guidance about not reviewing CodeQL code and were being misinterpreted as relevant to code review rather than code editing.
- Removes the "When editing .ql and .qll files" section that contained autoformatting instructions
- Eliminates confusion between code editing and code review instructions
- Maintains the existing guidance about reviewing .ql/.qll files only for typos and comments
geoffw0
approved these changes
Jul 28, 2025
Contributor
geoffw0
left a comment
geoffw0
left a comment
There was a problem hiding this comment.
OK, lets merge this, and I'll make a new PR to reintroduce a more refined version of the additional instructions when I get around to it.
Are you aware of any way to test the effect of changes on copilot reviews before merging them?
Contributor
Author
Unfortunately no. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The instructions about formatting was confusing CCR quite a lot. Firstly they caused it to regain confidence in editing QL effectively undoing the instruction above about not reviewing QL (example: #20121 (comment)). Secondly, it mistook the notes about formatting to be relevant for CCR (example: #20127 (comment))