Skip to content

Conversation

@ashleyvansp
Copy link
Contributor

@ashleyvansp ashleyvansp commented Jul 17, 2025

Minor changes to the markdown for workload groups:

  1. The heading for deleted workload groups didn't match other workload group changes, so this PR changes it from H4 to H3
  2. The property WorkloadGroup.RequestRateLimitPolicies is an unordered list, but it was being compared as an ordered list which was giving false positives and had poor markdown formatting. This PR changes the property to PolicyList<T>, that inherits from List<T> and overrides Equals and ToString to perform order-independent comparison.

Copilot AI review requested due to automatic review settings July 17, 2025 21:29
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes formatting issues in the markdown output for workload group changes in the KustoSchemaTools project. The changes improve consistency in heading levels and fix the display of list properties.

  • Updates the heading format for deleted workload groups from H4 to H3 for consistency
  • Adds proper handling for enumerable properties in markdown formatting by converting them to bracketed string representations

@ashleyvansp ashleyvansp merged commit 6823a19 into main Jul 17, 2025
5 checks passed
@ashleyvansp ashleyvansp deleted the ashleyvansp/fixFormat branch July 17, 2025 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants