Skip to content

fix: skip published MCP release tags #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jlitola merged 1 commit into from
Jun 23, 2026
Merged

fix: skip published MCP release tags #190

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions .github/workflows/mcp-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,13 +129,21 @@ jobs:
echo "version=$VERSION" >> "$GITHUB_OUTPUT"
echo "tag=$TAG" >> "$GITHUB_OUTPUT"

if npm view "@githits/mcp@$VERSION" version >/dev/null 2>&1; then
NPM_PUBLISHED=true
echo "npm_published=true" >> "$GITHUB_OUTPUT"
else
NPM_PUBLISHED=false
echo "npm_published=false" >> "$GITHUB_OUTPUT"
fi

TAG_EXISTS=false
TAG_REF="refs/tags/$TAG"
if git rev-parse --verify "$TAG_REF^{commit}" >/dev/null 2>&1; then
TAG_EXISTS=true
TAG_COMMIT=$(git rev-parse "$TAG_REF^{commit}")
HEAD_COMMIT=$(git rev-parse HEAD)
if [ "$TAG_COMMIT" != "$HEAD_COMMIT" ]; then
if [ "$NPM_PUBLISHED" != "true" ] && [ "$TAG_COMMIT" != "$HEAD_COMMIT" ]; then
echo "::error::Existing tag $TAG points to $TAG_COMMIT, not HEAD $HEAD_COMMIT"
exit 1
fi
Expand All @@ -150,14 +158,11 @@ jobs:
echo "release_exists=false" >> "$GITHUB_OUTPUT"
fi

if npm view "@githits/mcp@$VERSION" version >/dev/null 2>&1; then
if [ "$NPM_PUBLISHED" = "true" ]; then
if [ "$TAG_EXISTS" != "true" ]; then
echo "::error::@githits/mcp@$VERSION is already published, but $TAG is missing. Refusing to mint an unverifiable release tag."
exit 1
fi
echo "npm_published=true" >> "$GITHUB_OUTPUT"
else
echo "npm_published=false" >> "$GITHUB_OUTPUT"
fi

- name: Create MCP git tag
Expand Down
12 changes: 12 additions & 0 deletions src/package-release-boundaries.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,10 +70,22 @@ describe("package release boundaries", () => {
const publishIndex = workflow.indexOf(
"- name: Publish @githits/mcp to npm",
);
const npmPublishedCheckIndex = workflow.indexOf(
'if npm view "@githits/mcp@$VERSION" version',
);
const tagHeadCheckIndex = workflow.indexOf(
"Existing tag $TAG points to $TAG_COMMIT, not HEAD $HEAD_COMMIT",
);

expect(workflow).toContain('TAG_REF="refs/tags/$TAG"');
expect(workflow).toContain('git rev-parse --verify "$TAG_REF^{commit}"');
expect(workflow).toContain(
'if [ "$NPM_PUBLISHED" != "true" ] && [ "$TAG_COMMIT" != "$HEAD_COMMIT" ]; then',
);
expect(workflow).toContain('git push origin "refs/tags/$TAG"');
expect(npmPublishedCheckIndex).toBeGreaterThan(-1);
expect(tagHeadCheckIndex).toBeGreaterThan(-1);
expect(npmPublishedCheckIndex).toBeLessThan(tagHeadCheckIndex);
expect(createTagIndex).toBeGreaterThan(-1);
expect(publishIndex).toBeGreaterThan(-1);
expect(createTagIndex).toBeLessThan(publishIndex);
Expand Down