Skip to content

Validate email addresses via InternetAddress instead of a hand-rolled regex - #66

Merged
takezoe merged 2 commits into
gitbucket:masterfrom
aadrian:email-validation-internetaddress
Sep 19, 2026
Merged

takezoe merged 2 commits into
gitbucket:masterfrom
aadrian:email-validation-internetaddress

Conversation

@aadrian

@aadrian aadrian commented Sep 18, 2026

Copy link
Copy Markdown
Member

Alternative to #63

  • Delegates to javax.mail.internet.InternetAddress#validate() instead of a regex — no new dependency, same parser GitBucket's mail-sending path already uses.
  • Adds tests, including the dot-placement (RFC 5322)

Comment thread src/main/scala/fr/brouillard/gitbucket/announce/service/AnnounceService.scala Outdated
@takezoe

takezoe commented Sep 19, 2026

Copy link
Copy Markdown
Member

@aadrian This looks good. Could you update the comment slightly?

@aadrian

aadrian commented Sep 19, 2026

Copy link
Copy Markdown
Member Author

@aadrian This looks good. Could you update the comment slightly?

Done !

@takezoe
takezoe merged commit 301e8c4 into gitbucket:master Sep 19, 2026
2 checks passed
@aadrian
aadrian deleted the email-validation-internetaddress branch October 8, 2026 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants