Skip to content

[tooling] Add pre-commit hooks using LeftHook#265

Open
jovnc wants to merge 2 commits intogit-mastery:mainfrom
jovnc:feat/left-hook
Open

[tooling] Add pre-commit hooks using LeftHook#265
jovnc wants to merge 2 commits intogit-mastery:mainfrom
jovnc:feat/left-hook

Conversation

@jovnc
Copy link
Collaborator

@jovnc jovnc commented Feb 17, 2026

@jovnc jovnc requested a review from Copilot February 17, 2026 13:59
@github-actions
Copy link

Hi @jovnc, thank you for your contribution! 🎉

This PR comes from your fork jovnc/exercises on branch feat/left-hook.

Before you request for a review, please ensure that you have tested your changes locally!

Important

The previously recommended way of using ./test-download.py is no longer the best way to test your changes locally.

Please read the following instructions for the latest instructions.

Prerequisites

Ensure that you have the gitmastery app installed locally (instructions)

Testing steps

If you already have a local Git-Mastery root to test, you can skip the following step.

Create a Git-Mastery root locally:

gitmastery setup

Navigate into the Git-Mastery root (defaults to gitmastery-exercises/):

cd gitmastery-exercises/

Edit the .gitmastery.json configuration file. You need to set the following values under the exercises_source key.

{
    # other fields...
    "exercises_source": {
        "username": "jovnc",
        "repository": "exercises",
        "branch": "feat/left-hook"
    }
}

Then, you can use the gitmastery app to download and verify your changes locally.

gitmastery download <your new change>
gitmastery verify

Checklist

  • (For exercises and hands-ons) I have verified that the downloading behavior works
  • (For exercises only) I have verified that the verification behavior is accurate

Important

To any reviewers of this pull request, please use the same instructions above to test the changes.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds pre-commit hooks using LeftHook to automatically run linting and type checking before commits. The implementation integrates with the existing CI tooling (ruff and mypy) to catch issues earlier in the development cycle.

Changes:

  • Added lefthook as a developer dependency
  • Modified setup script to install git hooks after dependency installation
  • Created lefthook configuration for pre-commit hooks (ruff linting, formatting, and mypy type checking)

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 3 comments.

File Description
requirements.txt Added lefthook package to developer tooling dependencies
setup.sh Added conditional logic to install lefthook git hooks after pip install
lefthook.yml Configured pre-commit hooks for ruff-lint, ruff-format, and mypy on Python files

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implementing Git hooks for linting and formatting

2 participants