custom shader: added cursor style and visibility uniforms #9572
+127
−68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClearAspect
changed the title
Contributor
Author
|
While I was working on another issue, I just realized I could have also used the surface mailbox to get the cursor style information from the surface renderer state. Seems like that's the better way to do it from my understanding and I'll happily rewrite this. |
ClearAspect
force-pushed
the
cursor-styles
branch
from
37d1982 to
17072c3
Compare
Specifically: iCurrentCursorStyle iPreviousCursorStyle iCurrentCursorVisible iPreviousCursorVisible Visibility calculated and updated independently from the typical cursor unifrom updates to preserve cursor style even when not in the viewport or set to be hidden
ClearAspect
force-pushed
the
cursor-styles
branch
from
17072c3 to
a8ccfe3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #9416
Specifically:
iCurrentCursorStyle
iPreviousCursorStyle
iCurrentCursorVisible
iPreviousCursorVisible
Visibility calculated and updated independently from the typical cursor uniform updates to preserve cursor style even when not in the viewport or set to be hidden
I used Claude-Code to initially navigate and gauge an understanding of the rendering system. Otherwise I authored the rest of the PR