Update dependency js-yaml to v5

package.json

@@ -14,7 +14,7 @@
     "ajv": "^8.20.0",
     "compare-versions": "^6.1.1",
     "github-slugger": "^2.0.0",
-    "js-yaml": "^4.2.0",
+    "js-yaml": "^5.0.0",
     "mdast-util-gfm": "^3.1.0",
     "mdast-util-to-markdown": "^2.1.2",
     "mdast-util-to-string": "^4.0.0",

src/config/reading.ts

@@ -26,11 +26,15 @@ export async function readConfig({
   return group("Reading release configuration", async () => {
     const yaml = await readConfigFile();
 
+    let base: Config;
+
     if (typeof yaml === "undefined") {
       info("No configuration found at .github/github-release-from-tag.yml");
+      base = validateConfig({});
+    } else {
+      base = parseConfig(yaml);
     }
 
-    const base = parseConfig(yaml);
     const overrides = getConfigOverrides(getInput, base);
     let checksum: ChecksumConfig,
       discussion: DiscussionConfig,
@@ -136,13 +140,9 @@ function getConfigOverrides(
   return Object.keys(overrides).length > 0 ? overrides : undefined;
 }
 
-function parseConfig(yaml: string | undefined): Config {
-  if (!yaml) return validateConfig({});
-
-  let parsed;
-
+function parseConfig(yaml: string): Config {
   try {
-    parsed = load(yaml);
+    return validateConfig(load(yaml));
   } catch (error) {
     const message = isError(error)
       ? JSON.stringify(error.message)
@@ -153,8 +153,6 @@ function parseConfig(yaml: string | undefined): Config {
       `Parsing of release configuration failed with ${message}. Provided value: ${original}`,
     );
   }
-
-  return validateConfig(parsed == null ? {} : parsed);
 }
 
 function parseAssets(getInput: GetInputFn): AssetConfig[] {

test/fixture/config/empty-object/.github/github-release-from-tag.yml

@@ -0,0 +1,2 @@
+# yaml-language-server: $schema=https://ghalactic.github.io/github-release-from-tag/schema/config.v6.schema.json
+{}

test/suite/unit/read-config.spec.ts

@@ -84,8 +84,8 @@ describe("readConfig()", () => {
     expect(actual).toEqual(expected);
   });
 
-  it("returns a default config the config file is empty", async () => {
-    chdir(join(fixturesPath, "empty"));
+  it("returns a default config when no config file exists", async () => {
+    chdir(join(fixturesPath, "none"));
     const actual = await readConfig({ getInput, group, info });
 
     const expected = {
@@ -109,29 +109,12 @@ describe("readConfig()", () => {
     expect(actual).toEqual(expected);
   });
 
-  it("returns a default config when no config file exists", async () => {
-    chdir(join(fixturesPath, "none"));
-    const actual = await readConfig({ getInput, group, info });
-
-    const expected = {
-      assets: [],
-      checksum: {
-        generateAssets: true,
-      },
-      discussion: {
-        category: "",
-        reactions: [],
-      },
-      draft: false,
-      generateReleaseNotes: false,
-      makeLatest: IF_NEW,
-      reactions: [],
-      summary: {
-        enabled: true,
-      },
-    };
+  it("throws when the config file is empty", async () => {
+    chdir(join(fixturesPath, "empty"));
 
-    expect(actual).toEqual(expected);
+    await expect(() => readConfig({ getInput, group, info })).rejects.toThrow(
+      "Parsing of release configuration failed",
+    );
   });
 
   it("throws an error if the config file contains invalid YAML", async () => {
@@ -194,7 +177,7 @@ describe("readConfig()", () => {
   });
 
   it("fills in checksum defaults when using action input overrides", async () => {
-    chdir(join(fixturesPath, "empty"));
+    chdir(join(fixturesPath, "empty-object"));
 
     const getInput = (name: string) =>
       name === "checksumGenerateAssets" ? "false" : "";
@@ -210,7 +193,7 @@ describe("readConfig()", () => {
   });
 
   it("fills in discussions defaults when using action input overrides", async () => {
-    chdir(join(fixturesPath, "empty"));
+    chdir(join(fixturesPath, "empty-object"));
 
     const getInput = (name: string) =>
       name === "discussionReactions" ? "eyes,+1" : "";
@@ -227,7 +210,7 @@ describe("readConfig()", () => {
   });
 
   it("fills in summary defaults when using action input overrides", async () => {
-    chdir(join(fixturesPath, "empty"));
+    chdir(join(fixturesPath, "empty-object"));
 
     const getInput = (name: string) =>
       name === "summaryEnabled" ? "false" : "";