Skip to content

Conversation

@sehr-m
Copy link
Member

@sehr-m sehr-m commented Dec 8, 2025

The "List Seer AI Models" api reference did not specify a regional url. Historically, these were added in manually, but we have since switched to spectacular to create our json. I have added a servers attribute to the base api and a catch that will add the attribute to the method info if servers are specified.

The watch command to test also had a legacy error that I fixed to properly see the changes. (This was moved to a separate PR as a frontend change)

To test follow these instructions: https://develop.sentry.dev/backend/api/public/#building-and-testing-locally

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@sehr-m sehr-m requested review from a team as code owners December 8, 2025 19:07
@github-actions github-actions bot added Scope: Frontend Automatically applied to PRs that change frontend components Scope: Backend Automatically applied to PRs that change backend components labels Dec 8, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2025

🚨 Warning: This pull request contains Frontend and Backend changes!

It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently.

Have questions? Please ask in the #discuss-dev-infra channel.

@sehr-m sehr-m removed the Scope: Frontend Automatically applied to PRs that change frontend components label Dec 8, 2025
@sehr-m sehr-m self-assigned this Dec 8, 2025
@sehr-m sehr-m requested a review from sergical December 8, 2025 19:45
@codecov
Copy link

codecov bot commented Dec 8, 2025

Codecov Report

❌ Patch coverage is 27.27273% with 8 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/sentry/apidocs/hooks.py 11.11% 8 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #104530      +/-   ##
===========================================
+ Coverage   73.47%    80.51%   +7.04%     
===========================================
  Files        9348      9352       +4     
  Lines      400237    400521     +284     
  Branches    25700     25700              
===========================================
+ Hits       294067    322490   +28423     
+ Misses     105702     77563   -28139     
  Partials      468       468              

Copy link
Member

@sergical sergical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image

looks good from the docs side of things

Copy link
Member

@JoshFerge JoshFerge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will our API docs site render the server information right now?

Copy link
Member

@JoshFerge JoshFerge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@sehr-m sehr-m merged commit b2cad78 into master Dec 9, 2025
66 of 67 checks passed
@sehr-m sehr-m deleted the sehr/fix/seer-model-api-docs branch December 9, 2025 00:38
ryan953 pushed a commit that referenced this pull request Dec 9, 2025
…104530)

<!-- Describe your PR here. -->
The "List Seer AI Models" api reference did not specify a regional url.
Historically, these were added in manually, but we have since switched
to spectacular to create our json. I have added a servers attribute to
the base api and a catch that will add the attribute to the method info
if servers are specified.

The watch command to test also had a legacy error that I fixed to
properly see the changes. (This was moved to a separate PR as a frontend
change)

To test follow these instructions:
https://develop.sentry.dev/backend/api/public/#building-and-testing-locally


<!--

  Sentry employees and contractors can delete or ignore the following.

-->

### Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated
in the State of Delaware in 2015 as Functional Software, Inc. and is
gonna need some rights from me in order to utilize my contributions in
this here PR. So here's the deal: I retain all rights, title and
interest in and to my contributions, and by keeping this boilerplate
intact I confirm that Sentry can use, modify, copy, and redistribute my
contributions, under Sentry's choice of terms.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants