-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
fix(api): Update List Seer AI Models to reflect that it is regional #104530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #104530 +/- ##
===========================================
+ Coverage 73.47% 80.51% +7.04%
===========================================
Files 9348 9352 +4
Lines 400237 400521 +284
Branches 25700 25700
===========================================
+ Hits 294067 322490 +28423
+ Misses 105702 77563 -28139
Partials 468 468 |
sergical
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
JoshFerge
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will our API docs site render the server information right now?
JoshFerge
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you!
…104530) <!-- Describe your PR here. --> The "List Seer AI Models" api reference did not specify a regional url. Historically, these were added in manually, but we have since switched to spectacular to create our json. I have added a servers attribute to the base api and a catch that will add the attribute to the method info if servers are specified. The watch command to test also had a legacy error that I fixed to properly see the changes. (This was moved to a separate PR as a frontend change) To test follow these instructions: https://develop.sentry.dev/backend/api/public/#building-and-testing-locally <!-- Sentry employees and contractors can delete or ignore the following. --> ### Legal Boilerplate Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

The "List Seer AI Models" api reference did not specify a regional url. Historically, these were added in manually, but we have since switched to spectacular to create our json. I have added a servers attribute to the base api and a catch that will add the attribute to the method info if servers are specified.
The watch command to test also had a legacy error that I fixed to properly see the changes. (This was moved to a separate PR as a frontend change)
To test follow these instructions: https://develop.sentry.dev/backend/api/public/#building-and-testing-locally
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.