Skip to content

Remove legacy session replay file attachment in favor of Session Replay envelope - #1493

Merged
tustanivsky merged 3 commits into
mainfrom
fix/legacy-replay-attachment
Jul 23, 2026
Merged

Remove legacy session replay file attachment in favor of Session Replay envelope#1493
tustanivsky merged 3 commits into
mainfrom
fix/legacy-replay-attachment

Conversation

@tustanivsky

@tustanivsky tustanivsky commented Jul 23, 2026

Copy link
Copy Markdown
Collaborator

This PR removes the legacy path that uploaded the session replay clip as a raw .mp4 file attachment on the crash event, now that the Session Replay product integration is fully functional across platforms.

Both paths were shipping the same recording in two different forms:

  • Native platforms (Windows/Linux/Mac): the plugin attached the staged .mp4 in the on_crash hook (GenericPlatformSentrySubsystem::OnCrash), while the native SDK's replay envelope pipeline (sentry__session_replay_flush_pending) also consumed the same clip.
  • Cocoa (macOS/iOS): AppleSentrySubsystem both called UploadSessionReplayForEvent (file attachment) and FAppleSentryReplayEnvelope::CaptureForCrashEvent (envelope).

Beyond being redundant, the two mechanisms actively conflicted on the crashpad backend - the envelope pipeline consumes and deletes the staged replay-<id>.mp4 while assembling the crash report. Since crashpad copies file attachments out-of-process at dump time (after the in-process on_crash hook and after the envelope flush already deleted the file) the file attachment was silently dropped (attachment couldn't be opened, skipping). So on crashpad the legacy path didn't even work; the envelope is the reliable delivery path.

Documentation:

Related items:

@tustanivsky
tustanivsky marked this pull request as ready for review July 23, 2026 09:03
tustanivsky added a commit to getsentry/sentry-docs that referenced this pull request Jul 23, 2026
@tustanivsky
tustanivsky merged commit 97c42d8 into main Jul 23, 2026
173 of 180 checks passed
@tustanivsky
tustanivsky deleted the fix/legacy-replay-attachment branch July 23, 2026 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants