Remove legacy session replay file attachment in favor of Session Replay envelope - #1493
Merged
Conversation
tustanivsky
marked this pull request as ready for review
July 23, 2026 09:03
jpnurmi
approved these changes
Jul 23, 2026
mujacica
approved these changes
Jul 23, 2026
tustanivsky
added a commit
to getsentry/sentry-docs
that referenced
this pull request
Jul 23, 2026
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the legacy path that uploaded the session replay clip as a raw
.mp4file attachment on the crash event, now that the Session Replay product integration is fully functional across platforms.Both paths were shipping the same recording in two different forms:
.mp4in theon_crashhook (GenericPlatformSentrySubsystem::OnCrash), while the native SDK's replay envelope pipeline (sentry__session_replay_flush_pending) also consumed the same clip.AppleSentrySubsystemboth calledUploadSessionReplayForEvent(file attachment) andFAppleSentryReplayEnvelope::CaptureForCrashEvent(envelope).Beyond being redundant, the two mechanisms actively conflicted on the crashpad backend - the envelope pipeline consumes and deletes the staged
replay-<id>.mp4while assembling the crash report. Since crashpad copies file attachments out-of-process at dump time (after the in-processon_crashhook and after the envelope flush already deleted the file) the file attachment was silently dropped (attachment couldn't be opened, skipping). So on crashpad the legacy path didn't even work; the envelope is the reliable delivery path.Documentation:
Related items: