Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions sentry_sdk/integrations/pyramid.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
import weakref

import sentry_sdk
from sentry_sdk.consts import SPANDATA
Comment thread
alexander-alderman-webb marked this conversation as resolved.
from sentry_sdk.integrations import DidNotEnable, Integration
from sentry_sdk.integrations._wsgi_common import RequestExtractor
from sentry_sdk.integrations.wsgi import SentryWsgiMiddleware
Expand Down Expand Up @@ -81,6 +82,18 @@ def sentry_patched_call_view(
if integration is None:
return old_call_view(registry, request, *args, **kwargs)

route_path = None
try:
route_path = request.matched_route.pattern
except Exception:
pass

server_span = sentry_sdk.get_current_scope()._server_segment_span
if server_span is not None and route_path is not None:
server_span.set_attribute(
SPANDATA.HTTP_ROUTE, request.matched_route.pattern
)
Comment thread
alexander-alderman-webb marked this conversation as resolved.

_set_transaction_name_and_source(
sentry_sdk.get_current_scope(), integration.transaction_style, request
)
Expand Down
23 changes: 23 additions & 0 deletions tests/integrations/pyramid/test_pyramid.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@

import sentry_sdk
from sentry_sdk import add_breadcrumb, capture_message
from sentry_sdk.consts import SPANDATA
from sentry_sdk.integrations.pyramid import PyramidIntegration
from sentry_sdk.serializer import MAX_DATABAG_BREADTH
from sentry_sdk.traces import SpanStatus
Expand Down Expand Up @@ -177,6 +178,28 @@ def test_transaction_style(
assert transaction_event["transaction_info"] == {"source": expected_source}


def test_http_route(
sentry_init,
get_client,
capture_items,
):
sentry_init(
integrations=[PyramidIntegration()],
traces_sample_rate=1.0,
trace_lifecycle="stream",
)

items = capture_items("span")

client = get_client()
client.get("/message/123456")

sentry_sdk.flush()

(segment,) = [item.payload for item in items if item.payload.get("is_segment")]
assert segment["attributes"][SPANDATA.HTTP_ROUTE] == "/message/{message_id}"


@pytest.mark.parametrize("max_value_length", [1024, None])
def test_large_json_request(
sentry_init, capture_events, route, get_client, max_value_length
Expand Down
Loading