ref(boto3): Move crumbs to integration - #7165
Merged
Merged
Conversation
Move subprocess breadcrumb creation from the centralized `maybe_create_breadcrumbs_from_span` hook into the stdlib integration's `Popen.__init__` wrapper. This makes breadcrumbs work for both legacy spans and streamed spans, and removes the dependency on span internals.
…-redis-breadcrumbs-to-integration
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 7bd4d0b. Configure here.
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
sentrivana
marked this pull request as draft
August 11, 2026 10:38
sentrivana
marked this pull request as ready for review
August 11, 2026 10:51
Contributor
Codecov Results 📊✅ 112448 passed | ⏭️ 6759 skipped | Total: 119207 | Pass Rate: 94.33% | Execution Time: 405m 37s 📊 Comparison with Base Branch
All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 2480 uncovered lines. Files with missing lines (1)
Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 90.22% 90.22% —%
==========================================
Files 193 193 —
Lines 25345 25361 +16
Branches 9286 9302 +16
==========================================
+ Hits 22866 22881 +15
- Misses 2479 2480 +1
- Partials 1427 1434 +7Generated by Codecov Action |
alexander-alderman-webb
approved these changes
Aug 11, 2026
ericapisani
approved these changes
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Set boto3 breadcrumbs in the integration directly, without relying on
maybe_create_breadcrumbs_from_span.Also, add breadcrumb tests to
test_s3.pyand remove themaybe_create_breadcrumbs_from_spanutil now that nothing needs it anymore.Issues
Closes #7067