test: Add streaming tests to test_sampling - #6784
Merged
Merged
Conversation
sentrivana
marked this pull request as ready for review
July 8, 2026 13:01
![sentry-warden[bot]](https://avatars.githubusercontent.com/in/2755838?s=60&v=4){kind=small}
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 0cc6fa5. Configure here.
sentrivana
marked this pull request as draft
July 8, 2026 13:03
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
sentrivana
marked this pull request as ready for review
July 8, 2026 13:06
Contributor
Codecov Results 📊✅ 90555 passed | ⏭️ 6302 skipped | Total: 96857 | Pass Rate: 93.49% | Execution Time: 313m 8s 📊 Comparison with Base Branch
All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 2444 uncovered lines. Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 89.74% 89.74% —%
==========================================
Files 192 192 —
Lines 23823 23823 —
Branches 8226 8226 —
==========================================
+ Hits 21378 21379 +1
- Misses 2445 2444 -1
- Partials 1349 1348 -1Generated by Codecov Action |
6 tasks
mgaligniana
pushed a commit
to mgaligniana/sentry-python
that referenced
this pull request
Aug 9, 2026
### Description Only ported tests that also make sense in streaming mode. For example, tests testing explicit `sampled` decisions as args to `start_transaction` were not ported. #### Issues Part of getsentry#5395 #### Reminders - Please add tests to validate your changes, and lint your code using `uv run ruff`. - Add GH Issue ID _&_ Linear ID (if applicable) - PR title should use [conventional commit](https://develop.sentry.dev/engineering-practices/commit-messages/#type) style (`feat:`, `fix:`, `ref:`, `meta:`) - For external contributors: [CONTRIBUTING.md](https://github.com/getsentry/sentry-python/blob/master/CONTRIBUTING.md), [Sentry SDK development docs](https://develop.sentry.dev/sdk/), [Discord community](https://discord.gg/Ww9hbqr)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Only ported tests that also make sense in streaming mode. For example, tests testing explicit
sampleddecisions as args tostart_transactionwere not ported.Issues
Part of #5395
Reminders
uv run ruff.feat:,fix:,ref:,meta:)